Override generateFromTypeSpec by the result in generateOutput.json#13394
Merged
Override generateFromTypeSpec by the result in generateOutput.json#13394
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR modifies how the generateFromTypeSpec flag is determined for .NET SDK automation in spec pull request scenarios. Instead of relying on package-level TypeSpec flags, the implementation now reads this value from the generateOutput.json file produced by the .NET automation script.
Key Changes:
- Reads
generateOutput.jsonto determine if TypeSpec is used for .NET SDKs in spec-pull-request mode - Removes the .NET exclusion from the initial tspconfig.yaml-based TypeSpec detection
- Adds error handling for missing
generateOutput.jsonfile
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| tools/spec-gen-sdk/src/automation/reportStatus.ts | Modified logic to read generateFromTypeSpec value from generateOutput.json for .NET SDKs in spec-pull-request mode; removed .NET exclusion from tspconfig.yaml check; added new imports for readTmpJsonFile, externalError, and getGenerateOutput |
| tools/spec-gen-sdk/package.json | Bumped package version from 0.9.4 to 0.9.5 |
| tools/spec-gen-sdk/package-lock.json | Updated lock file to reflect version 0.9.5 |
| tools/spec-gen-sdk/CHANGELOG.md | Added entry for version 0.9.5 documenting the generateFromTypeSpec override for .NET |
Files not reviewed (1)
- tools/spec-gen-sdk/package-lock.json: Language not supported
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
chidozieononiwu
approved these changes
Dec 18, 2025
JiaqiZhang-Dev
pushed a commit
that referenced
this pull request
Dec 22, 2025
…13394) * Override generateFromTypeSpec by the result in generateOutput.json * Update tools/spec-gen-sdk/src/automation/reportStatus.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolved an issue of not setting
SDK Validation - .NETas required check when generation fails.Repro PR